Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT BREAKING] remove globals build for 3.x #5381

Merged
merged 4 commits into from
Mar 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,29 +103,6 @@ export default DS.Model.extend({
});
```

If you're using globals (that is, not something like ember-cli), your
models would look like this:

```js
var attr = DS.attr;
var hasMany = DS.hasMany;
var belongsTo = DS.belongsTo;

App.BlogPost = DS.Model.extend({
title: attr('string'),
createdAt: attr('date'),

comments: hasMany('comment')
});

App.Comment = DS.Model.extend({
body: attr('string'),
username: attr('string'),

post: belongsTo('blog-post')
});
```

### A Brief Note on Adapters

Without immediately diving in to the depths of the architecture, one
Expand Down
8 changes: 0 additions & 8 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ STEPS:
* `git tag vX.Y.Z-beta.n`
* Do a production build.
* `rm -rf node_modules; yarn install; npm run build:production`
* Publish to Bower
* Commit built globals code to the https://github.com/components/ember-data repo
* `cp dist/globals/* ../components-ember-data/`
* Publish Rubygems
* `gem build ember-data-source.gemspec`
* `gem push ember-data-source-2.4.0.beta.1.gem`
* Publish to NPM
* `npm publish` or `npm publish --tag beta` or `npm publish --tag release-1-13`
* Update the `/builds/` page on the website
Expand All @@ -37,8 +31,6 @@ STEPS:
* Write a Release Blog Post (Does not happen for beta releases)
* Commits since last release: `git log --oneline release..beta | wc -l`.
* Contributors since last release: `git shortlog -s -n release...beta | wc -l`
* Submit a Pull request to the https://github.com/ember-cli/ember-cli to update the version of Ember Data
* (per request by @rwjblue and is also a great idea to make upgrading/new apps easier)
* Bump version in package.json back to a canary version
* For beta.1 releases, branch beta from master and update https://github.com/emberjs/data/blob/master/config/features.json to have `false` values instead of `null` and update the version in package.json

Expand Down
63 changes: 0 additions & 63 deletions bin/bower-ember-data-build

This file was deleted.

1 change: 0 additions & 1 deletion bin/publish-builds
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ echo -e "PULL_REQUEST: ${TRAVIS_PULL_REQUEST}\n"

if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then
./bin/publish-to-s3.js
./bin/bower-ember-data-build
fi
3 changes: 3 additions & 0 deletions bin/publish-to-s3.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/usr/bin/env node

// This publish script remains in order to publish the yui-docs to S3, builds no
// longer need to be published to S3.
//
// To invoke this from the commandline you need the following to env vars to exist:
//
// S3_BUCKET_NAME
Expand Down
4 changes: 1 addition & 3 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
var EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
var merge = require('broccoli-merge-trees');
var Funnel = require('broccoli-funnel');
var globals = require('./lib/globals');
var yuidoc = require('./lib/yuidoc');
var StripClassCallCheck = require('babel6-plugin-strip-class-callcheck');
var path = require('path');
Expand Down Expand Up @@ -51,8 +50,7 @@ module.exports = function(defaults) {
var appTree = app.toTree();

if (process.env.EMBER_ENV === 'production') {
var globalsBuild = globals('addon', 'config/package-manager-files');
return merge([appTree, globalsBuild, yuidoc()]);
return merge([appTree, yuidoc()]);
} else {
return appTree;
}
Expand Down
18 changes: 0 additions & 18 deletions ember-data-source.gemspec

This file was deleted.

33 changes: 0 additions & 33 deletions lib/amd-build.js

This file was deleted.

9 changes: 0 additions & 9 deletions lib/ds-global.js

This file was deleted.

38 changes: 0 additions & 38 deletions lib/ember-data-shims.js

This file was deleted.

6 changes: 0 additions & 6 deletions lib/ember-shim.js

This file was deleted.

12 changes: 0 additions & 12 deletions lib/globals.js

This file was deleted.

114 changes: 0 additions & 114 deletions lib/javascripts.js

This file was deleted.