Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Use @ember/ordered-set to avoid deprecations. #5372

Merged
merged 1 commit into from
Mar 7, 2018
Merged

[BUGFIX beta] Use @ember/ordered-set to avoid deprecations. #5372

merged 1 commit into from
Mar 7, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 7, 2018

Ember will deprecate usage of Ember.OrderedSet (likely in 3.2 or 3.3), and as part of that process the implementation has been extracted to an addon @ember/ordered-set. The addon intelligently avoids shipping duplicated implementations, and is compatible with newer and older Ember versions.

Closes #5254

@rwjblue
[BUGFIX beta] Use @ember/ordered-set to avoid deprecations.
d478a04 
Ember will deprecate usage of `Ember.OrderedSet` (likely in 3.2 or
3.3), and as part of that process the implementation has been extracted
to an addon `@ember/ordered-set`. The addon intelligently avoids
shipping duplicated implementations, and is compatible with newer _and_
older Ember versions.
@rwjblue rwjblue mentioned this pull request Mar 7, 2018
Merged
@rwjblue rwjblue merged commit fb5b395 into emberjs:master Mar 7, 2018
@rwjblue rwjblue deleted the migrate-to-external-ordered-set branch March 7, 2018 17:41
@sly7-7
Copy link
Contributor

sly7-7 commented Mar 16, 2018

I encounter this warning when building the app:
'@ember/ordered-set' is imported by tmp/rollup-cache_path-O3J4AVcJ.tmp/-private/system/ordered-set.js, but could not be resolved – treating it as an external dependency
running on ember-cli: 3.0.0

@bmac
Copy link
Member

bmac commented Mar 16, 2018

@sly7-7 do you have @ember/ordered-set installed in your node_modules folder?

@rwjblue
Copy link
Member Author

rwjblue commented Mar 16, 2018

Maybe I missed adding it as an external to the roll up part of the build?

@rwjblue
Copy link
Member Author

rwjblue commented Mar 16, 2018

Should have gone in this list:

data/index.js

Line 180 in dc25232

external: [

😭 sorry

@bmac
Copy link
Member

bmac commented Mar 16, 2018

@sly7-7 is on it.

@broerse
Copy link

broerse commented Mar 26, 2018 •
edited
Loading

I encounter this warning when building the app:
'@ember/ordered-set' is imported by tmp/rollup-cache_path-O3J4AVcJ.tmp/-private/system/ordered-set.js, but could not be resolved – treating it as an external dependency
running on ember-cli: 3.1.0 but not in 3.0.0

@bmac
Copy link
Member

bmac commented Mar 26, 2018

That warning is fixed by #5383. Looks like I missed cherry-picking that commit into the 3.1 release. I'll release a 3.1.1 patch tomorrow with that fix.

@sly7-7 sly7-7 mentioned this pull request Mar 27, 2018
Merged
@bmac
Copy link
Member

bmac commented Mar 27, 2018

Ember Data 3.1.1 has been published with a fix for this warning.

@broerse
Copy link

broerse commented Mar 27, 2018

@bmac Yes it is fixed again. Thanks!

@jherdman
Copy link

This deprecation seems to be raised in 3.3.1 as well.

@runspired
Copy link
Contributor

@jherdman I think it is a different deprecation (the one where we aren't using new which is resolved by #5557 and which needs backported to 3.1, 3.2, 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmac bmac bmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rwjblue @sly7-7 @bmac @broerse @jherdman @runspired