Avoid bower usage in config/ember-try.js #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some issues are being resolved here still, see comments in ember-cli/ember-cli#7536 for details... I'm trying to get this landed soon and will keep you updated... |
rwjblue
force-pushed
the
rm-bower
branch
2 times, most recently
from
cdeeaec
to
f794ee8
Compare
|
OK, finally got things straightened out here and this is ready for another review. Some background reading on the approach: |
rwjblue
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stealing @rwjblue's magic from ember-cli/ember-cli#7536
This pr also drops ember try tests for Ember 1.13, 2.4 and 2.8 which I think is ok since it targets Ember Data 3.0.