blueprints/serializer-test: Add RFC232 variants #5298
Conversation
| import { setupTest } from 'ember-qunit'; | ||
| import { run } from '@ember/runloop'; | ||
|
|
||
| module('serializer:<%= dasherizedModuleName %>', '<%= friendlyTestDescription %>', function(hooks) { |
There was a problem hiding this comment.
Should only be two arguments here (friendlyTestDescription and the function(hooks) {}...
|
@rwjblue fixed... sorry about that... thoughts on any of the two testing styles here? |
| // Replace this with your real tests. | ||
| test('it exists', function(assert) { | ||
| let store = this.owner.lookup('service:store'); | ||
| let serializer = this.owner.factoryFor('serializer:<%= dasherizedModuleName %>').create({ store }); |
There was a problem hiding this comment.
I think this should be .lookup (not factoryFor().create()) because serializers are singleton...
There was a problem hiding this comment.
you need the store initialized on the serializer though, which lookup doesn't automatically do
is that something that should be addressed upstream?
There was a problem hiding this comment.
Haha, this seems sorta bonkers. I submitted #5300 to simplify greatly 😺
There was a problem hiding this comment.
@alexander-alvarez - Even without #5300, we should do store.serializerFor(<%= dasherizedModelName %>) here as that is the public API for getting a given things serializer. There are a few fallbacks that Ember Data handles nicely for you (e.g. use application if you don't have a model specific one) and we should go through the same common API.
There was a problem hiding this comment.
understood 👍
|
|
||
| let serializedRecord = record.serialize(); | ||
|
|
||
| assert.ok(serializedRecord); |
There was a problem hiding this comment.
This should probably use some sort of assert.deepEqual
There was a problem hiding this comment.
Fine with whatever -- I simply copied the old ones https://github.com/emberjs/data/blob/master/blueprints/serializer-test/qunit-files/tests/unit/__path__/__test__.js#L14
There was a problem hiding this comment.
I was playing around with adding assert.deepEqual({}, serializedRecord); in my repo, and realized that if you've already implemented the model for which a serializer is being generated, at the moment we can't generate a test case that will pass when generated + when using the equality check.
I was under the impression that generated test cases should always pass when initially generated with a new model (e.g. running ember g serializer should generate a serializer and a passing test)-- do we want to continue to have this behavior?
not sure the test failure is related @rwjblue |
|
Restarted! |
|
@rwjblue didn't realize -- it's failing on canary |
|
Looks like the canary issue has be resolved and this is now passing again. @rwjblue has your issue been addressed? |
See #5292
Had questions on what we wanted the default to be so I implemented both
@Turbo87 @bmac