Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprints/adapter-test: Add RFC232 variants #5296

Merged
merged 2 commits into from
Dec 22, 2017

Conversation

alexander-alvarez
Copy link
Contributor

See #5292

import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';

module('adapter:<%= dasherizedModuleName %>', '<%= friendlyTestDescription %>', function(hooks) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be three arguments here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated... sorry about that..

@rwjblue rwjblue merged commit d057024 into emberjs:master Dec 22, 2017
@alexander-alvarez alexander-alvarez deleted the adapter-test branch December 22, 2017 14:49
@alexander-alvarez alexander-alvarez restored the adapter-test branch December 22, 2017 14:49
@alexander-alvarez alexander-alvarez deleted the adapter-test branch December 22, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants