Remove support/deprecation for normalizeHash in 3.0.0 #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Dec 19, 2017
addon/serializers/rest.js
Outdated
| @@ -161,13 +161,6 @@ const RESTSerializer = JSONSerializer.extend({ | |||
| @return {Object} | |||
| */ | |||
| normalize(modelClass, resourceHash, prop) { | |||
There was a problem hiding this comment.
Should we remove this whole override instead? It seems like it only calls this._super after the changes, which might mean we can remove the whole function...
bmac
force-pushed
the
normalize-hash-deprecation
branch
from
0752a5d
to
c2e0e32
Compare
bmac
force-pushed
the
normalize-hash-deprecation
branch
from
c2e0e32
to
3e711e4
Compare
rwjblue
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.