[BUGFIX] Fix store.createRecord with belongsTo when model has @each o… #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Digging into this PR. I'm not familiar with the issue but seems like a thing we should fix if broken, and there's at least one other bug report I've seen float by lately that looked similar. |
|
This was fixed in #5369 |
|
Just wanted to circle back and say thank you very much @mattraydub ! I find your failing tests super helpful :) We should rope you in to doing more of them :D |
|
@runspired glad I was able to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing belongsTo relationship during create (on Model with property using @each observer) the InternalModel.getRecord actually recurses on itself thus calling the modelFactory create 2 times. This is only happening when there is something watching a path on the created model using the @each observer.
This test and fix ensures the create is only called once.