Move initialize-store-service.js out of the instance-initializers dir… #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory. That directory seems to be suggesting to ember-load-initializers that it is a full initializer object and causing an exception to be thrown in the globals build. Fixes emberjs#5118
I vaguely think that this is the approach I would take, but either is fine IMHO... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ectory.
That directory seems to be suggesting to ember-load-initializers that
it is a full initializer object and causing an exception to be thrown
in the globals build.
Fixes #5118
@rwjblue would you mind reviewing this and letting me know if this is the right approach? I originally tried renaming
addon/instance-initializers/initialize-store-service.jstoaddon/instance-initializers/ember-data.jsexport a full object and hadapp/instance-initializers/ember-data.jsreport that object (following the pattern used in the instance-initializers generated from the blueprints). However I ran into a BroccoliMergeTrees error and I didn't feel confident in my broccoli skills to debug the Ember Data's build atm.