[BUGFIX release] Fix global build #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global build of ember-data has been broken since emberjs#4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global.
tricknotes
force-pushed
the
fix-global-build
branch
from
1478ef7 to
ef6e7e6
Compare
|
Thanks @tricknotes. |
bmac
pushed a commit
that referenced
this pull request
Jul 21, 2017
The global build of ember-data has been broken since #4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global. (cherry picked from commit 17bf1b7)
bmac
pushed a commit
that referenced
this pull request
Jul 21, 2017
The global build of ember-data has been broken since #4823. When `ember-data.js` is loaded, the following error is occured: ``` Uncaught Error: Could not find module `ember-data/index` imported from `ember-data/initializers/ember-data` ``` A reproduction code is just simple: ``` <!DOCTYPE html> <html> <head> <script src="http://builds.emberjs.com/tags/v2.13.1/ember.prod.js"></script> <script src="http://builds.emberjs.com/tags/v2.14.3/ember-data.js"></script> </head> <body> <h1>Hello, Ember!</h1> </body> </html> ``` The reason of this error is that the broccoli builds the module named "*/index" into `*` for global build. But loader.js couldn't resolve `ember-data/index` as `ember-data`. So the `ember-data/index` module should be to as just `ember-data` to be compatible with NPM package and global. (cherry picked from commit 17bf1b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global build of ember-data has been broken since #4823.
When
ember-data.jsis loaded, the following error is occured:A reproduction code is just simple:
The reason of this error is that the broccoli builds the module named "*/index" into
*for global build.But loader.js couldn't resolve
ember-data/indexasember-data.So the
ember-data/indexmodule should be to as justember-datato becompatible with NPM package and global.