-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX BETA]: Fixed export regression. ember-data/transform
to be default.
#5008
Conversation
addon/transform.js
Outdated
@@ -1 +1 @@ | |||
export { Transform } from './-private'; | |||
export { Transform as Default } from './-private'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be lowercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 Yea ... I'm not sure how that worked. I guess the tests don't exercise that.
9e05cc5
to
2f64d11
Compare
~~@stefanpenner So it looks like the
|
…export using `default`.
2f64d11
to
f79d398
Compare
Err. Actually I'm not actually sure if Who knew one line of code could be so complicated 😜 |
@workmanw this is fixed elsewhere I thought it landed |
@runspired Hmm. It's not in master or beta. I also checked the recent most PRs. I don't see any sign of it. Maybe it was in a close (unmerged) PR? EDIT: One thing I did notice is that the transforms were briefly in the |
Thanks @workmanw. |
The bug that this PR fixed just got released in 2.14.0, but this fix isn't in that release, it's in the 2.15 track, so this regression exists in the latest release |
Thanks for the heads up @bendemboski. I missed this when cherry picking commits for the release. I'll release a 2.14.1 with this commit as soon as I get a chance. |
Ember Data 2.14.1 has been published with this fix. |
@stefanpenner made reference to this in the original PR (24f4120#commitcomment-22121947), but I think it was just overlooked. Either way this created a regression for us when using:
import Transform from 'ember-data/transform';
.