-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelted some our builds a bit (3KB savings) #4920
Conversation
Analyze modules appears present twice. Also this functionality exists as part of broccoli-concat see debug usage at: https://github.com/broccolijs/broccoli-concat/blob/master/README.md (It also provides gzip size) |
The rest looks good |
@stefanpenner already removed :P github just laggy today |
@stefanpenner RE broccoli-concat also having this functionality, happy to just remove that script from here, I wrote it to be able to grab the prod versions of assets for putting into our HARRemixes. |
lib/analyze-modules.js
Outdated
@@ -0,0 +1,86 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- lets remove the analysis code, deferring to https://github.com/broccolijs/broccoli-concat#debug-usage
- squash commits (or I can do this during merge)
- shipit
dccceb5
to
1945864
Compare
1945864
to
a2785b2
Compare
@stefanpenner module removed and commits squashed. |
This takes current master's
addon/
modules from 160.04KB and 84 modules in prod to 157.01 KB and 79 modulesIt also adds the script
lib/analyze-modules.js
that can be used for a granular breakdown of the ember-data modules in a minified production version of vendor.jsExample: