[BUGFIX beta] Rename relationship.destroy to removeInverseRelationships
#4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduquej
changed the title
sduquej
changed the title
relationship.destroy to removeInverseRelationships
bmac
approved these changes
Mar 27, 2017
|
Looks good @sduquej. Would you mind rebasing this pr? I just want to make sure it passes CI since its renaming a method. |
sduquej
force-pushed
the
rename-relationship-destroy
branch
from
97895b3 to
a9f91de
Compare
|
Done! 🤞 |
|
Thanks @sduquej. |
|
We should revert this PR, |
|
Furthermore, this was definitely not a bugfix, or needed for beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4752
The semantics of destroy have changed since 2f18405. This PR renames the method to convey better what it does.