Fix tests in release branch RE: factoryFor. #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds various conditionals and updates assertions to match expectations for each of 1.13, 2.4, 2.8, and 2.12.
|
Thanks @rwjblue. |
bmac
pushed a commit
that referenced
this pull request
Mar 17, 2017
* Update test suite to test 2.4 and 2.8 LTS's. * Ensure factoryFor related tests pass on release branch. Adds various conditionals and updates assertions to match expectations for each of 1.13, 2.4, 2.8, and 2.12. (cherry picked from commit ba7f462)
bmac
pushed a commit
that referenced
this pull request
Mar 17, 2017
* Update test suite to test 2.4 and 2.8 LTS's. * Ensure factoryFor related tests pass on release branch. Adds various conditionals and updates assertions to match expectations for each of 1.13, 2.4, 2.8, and 2.12. (cherry picked from commit ba7f462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.