Refactor the detection / warnings around ember-cli-shims. #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I picked this back up today and got pretty confused by the conditionals here. I found that rewriting them with variable names actually helped my understanding quite a bit.
bmac
pushed a commit
that referenced
this pull request
Apr 28, 2017
I picked this back up today and got pretty confused by the conditionals here. I found that rewriting them with variable names actually helped my understanding quite a bit. (cherry picked from commit 4cf156b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked this back up today and got pretty confused by the conditionals here. I found that rewriting them with variable names actually helped my understanding quite a bit.