Optimise has many notifications #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjdivad
reviewed
Mar 9, 2017
|
Good point. |
stefanpenner
suggested changes
Mar 9, 2017
addon/-private/system/many-array.js
Outdated
| // we found a change | ||
| this.arrayContentWillChange(diff.firstChangeIndex, diff.removedCount, diff.addedCount); | ||
| // It’s possible the parent side of the relationship may have been unloaded by this point | ||
| if (_objectIsAlive(this)) { |
There was a problem hiding this comment.
if we are not alive, i think we should just skip the whole function, exiting at line 145.
stefanpenner
suggested changes
Mar 9, 2017
There was a problem hiding this comment.
Some remaining nit-picks. Then this looks good to merge, thanks for this great contribution!
paired with @igorT
addon/-private/system/diff-array.js
Outdated
| removedCount: <integer> // 0 if no change | ||
| } | ||
| */ | ||
| const diffArray = function (oldArray, newArray) { |
There was a problem hiding this comment.
do you mind if we do export default function diffArray
- This lets readers easily see (without scanning the full file) that this method is the default export
addon/-private/system/many-array.js
Outdated
| let toSet = this.canonicalState; | ||
|
|
||
| //a hack for not removing new records | ||
| //TODO remove once we have proper diffing | ||
| let newRecords = this.currentState.filter( | ||
| const newRecords = this.currentState.filter( |
addon/-private/system/many-array.js
Outdated
| //TODO Figure out to notify only on additions and maybe only if unloaded | ||
| this.relationship.notifyHasManyChanged(); | ||
| // diff to find changes | ||
| const diff = diffArray(this.currentState, toSet); |
addon/-private/system/many-array.js
Outdated
|
|
||
| assert(`You cannot add '${type.modelName}' records to this polymorphic relationship.`, !get(this, 'isPolymorphic')); | ||
| record = store.createRecord(type.modelName, hash); | ||
| const record = store.createRecord(type.modelName, hash); |
stefanpenner
approved these changes
Mar 10, 2017
|
eslint looks unhappy: |
|
🎉 🎉 🎉 |
|
:) We got there eventually |
|
between this and #4842 hasMany relationships have gotten some good TLC these last few weeks. |
|
I just found another 10x improvement... more to come |
|
@BryanCrotaz nice. We are also working on more perf things. Sounds like ember-data will be quite different perf wise soon. Can't wait to see what your working on! |
|
@stefanpenner this is what we're working on... |
runspired
added a commit
to runspired/data
that referenced
this pull request
Apr 25, 2018
This reverts commit 34aef62.
runspired
added a commit
that referenced
this pull request
Apr 25, 2018
Revert "Optimise has many notifications (#4850)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff many arrays properly to find the smallest contiguous block describing the change
Particularly important when polling server for changes with a repeating model.reload() or relationship.update()