-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup things and stuff #4831
Merged
Merged
Cleanup things and stuff #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failing test:
|
stefanpenner
force-pushed
the
cleanup-things-and-stuff
branch
2 times, most recently
from
March 1, 2017 17:24
357071e
to
a144a4a
Compare
* consistent promise/run-loop usage * let/const * misc consistency
stefanpenner
force-pushed
the
cleanup-things-and-stuff
branch
from
March 1, 2017 17:53
a144a4a
to
e527d2f
Compare
hjdivad
approved these changes
Mar 1, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
hjdivad
force-pushed
the
cleanup-things-and-stuff
branch
from
March 1, 2017 18:37
9d573a4
to
a0bab0b
Compare
hjdivad
force-pushed
the
cleanup-things-and-stuff
branch
from
March 1, 2017 21:17
a0bab0b
to
bf59a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.