Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Adapter#serialize by using snapshot.serialize() since they d… #4637

Merged
merged 1 commit into from
Nov 19, 2016

Conversation

bmac
Copy link
Member

@bmac bmac commented Nov 9, 2016

…uplicate the same logic

cc @wecc

@bmac bmac force-pushed the simplify-adapter-serializer branch from 292c67a to 2455f71 Compare November 9, 2016 21:59
@sly7-7
Copy link
Contributor

sly7-7 commented Nov 10, 2016

After a quick search about adapter.serialize, it seems like it's never called in the repository. Maybe we could even deprecate it and remove it for 3.0 ?

@bmac
Copy link
Member Author

bmac commented Nov 10, 2016

That sounds good to me @sly7-7. I think the same thing could happen for store#serialize

@sly7-7
Copy link
Contributor

sly7-7 commented Nov 14, 2016

@bmac I just wonder what we want as a public api for serializing a record. Do we want only keep record.serialize(options) ?
Nevermind, store.serialize is private, so I guess we can simply remove that one (even without deprecation)

@bmac
Copy link
Member Author

bmac commented Nov 14, 2016

I think record.serialize(options) and snapshot.serialize(options) is the way to go.

@bmac bmac merged commit cebcbed into emberjs:master Nov 19, 2016
@bmac bmac deleted the simplify-adapter-serializer branch November 19, 2016 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants