Update the relationship docs to remove some references to a globals s… #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,7 +171,7 @@ export const RelationshipsClassMethodsMixin = Ember.Mixin.create({ | |||
| }); | |||
| ``` | |||
|
|
|||
| Calling `App.Post.typeForRelationship('comments')` will return `App.Comment`. | |||
| Calling `postRecord.constructor.typeForRelationship('comments')` will return `Comment`. | |||
There was a problem hiding this comment.
If I recall correctly, @fivetanley had some thoughts of not advertising constructor publicly? Just want to double check...
There was a problem hiding this comment.
Hmm, also it looks like typeForRelationship needs the store to be passed as 2nd argument...
bmac
force-pushed
the
clean-up-some-references-to-app
branch
from
a75a7ea to
9f1d6b1
Compare
pangratz
reviewed
Oct 23, 2016
There was a problem hiding this comment.
Can you add the missing @param {DS.Store} store argument to the inverseFor doc, while you're at it?
Thanks!
| @@ -171,7 +171,7 @@ export const RelationshipsClassMethodsMixin = Ember.Mixin.create({ | |||
| }); | |||
| ``` | |||
|
|
|||
| Calling `App.Post.typeForRelationship('comments')` will return `App.Comment`. | |||
| Calling `postRecord.constructor.typeForRelationship('comments', store)` will return `Comment`. | |||
There was a problem hiding this comment.
@fivetanley if I recall correctly you had some thoughts on not advertising the use of constructor?
@bmac what do you think of using store.modelFor("post").typeForRelationship("comments") instead?
bmac
force-pushed
the
clean-up-some-references-to-app
branch
from
9f1d6b1 to
2a66b5c
Compare
bmac
force-pushed
the
clean-up-some-references-to-app
branch
from
2a66b5c to
65006cc
Compare
|
Done @pangratz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tyle namespace