[BUGFIX beta] flag ds-serialize-ids-and-types should not be enabled by default #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lkhaas. I think the I'd like to know which deprecation warning you are seeing from this feature. Also since this feature has been released we can now remove this feature flag. If you'd like to make a PR similar to this one https://github.com/emberjs/data/pull/4348/files that removes all of the references to |
|
I'm seeing deprecation warnings when running the tests, but completely missed its release in 2.6. I'll go ahead and make a PR to remove the flag. Thanks for the example PR. |
|
Closing in favor of removing the feature flag in PR #4451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is enabled by default in the repo and therefore throwing deprecation warnings.