Moved the adapter errors into the public API space. #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workmanw
force-pushed
the
adapter-errors-public
branch
from
841e2db
to
d049f03
Compare
|
LGTM 👍 @workmanw can you add corresponding tests to tests/unit/modules-test.js? |
workmanw
force-pushed
the
adapter-errors-public
branch
from
d049f03
to
5074de5
Compare
…documented as public and required for people implementing a customer adapter.
workmanw
force-pushed
the
adapter-errors-public
branch
from
5074de5
to
4c3e7d2
Compare
|
Thanks @workmanw |
|
Excellent. Thanks @bmac! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors are documented as public and required for people implementing a customer adapter. Example: http://emberjs.com/api/data/classes/DS.InvalidError.html#stq=&stp=0
We have to use them in our app so I feel like I should be able to import them from a public import path.
I wasn't sure if I should have moved the
errors.jsfile from the private space or just created a new one in the public space that imported from the private space and re-exported. I decided to do the former, but I'd be happy to do the later.