Modified the setup-ember-dev test helper to use ember-metal/debugs override hooks
#4260
Conversation
|
This is great @workmanw! What are the next steps? Do you want some help fixing the failures due to deprecations? |
| const AVAILABLE_ASSERTIONS = ['expectAssertion', 'expectDeprecation', 'expectNoDeprecation', 'expectWarning', 'expectNoWarning']; | ||
|
|
||
| function getDebugFunction(name) { | ||
| return Ember[name]; | ||
| if (debugModule && debugModule.getDebugFunction) { | ||
| return debugModule.getDebugFunction(); |
There was a problem hiding this comment.
Is this missing the name being passed to getDebugFunction?
There was a problem hiding this comment.
Ooops! Good catch. I'll fix that.
|
@bmac I guess I'm not completely sure about what the next steps should be. Maybe we should catalog the deprecations and see how easy they are to solve. |
workmanw
force-pushed
the
setup-ember-dev-use-metal-hooks
branch
2 times, most recently
from
46691f1 to
ba15b84
Compare
|
Basically I am 💯 👍 on this. My initial implementation was never the way to go anyway and using
I am not sure I follow completely: if I run the code in this PR locally via |
|
@pangratz Yea ... you're absolutely right. I swear there were test failures last night, but they're all gone today. ¯_(ツ)_/¯. I'll push up a change to get ember 1.13 working. |
workmanw
force-pushed
the
setup-ember-dev-use-metal-hooks
branch
from
ba15b84 to
fd9dc9e
Compare
…override hooks. Ember no longer uses `Ember.deprecate` internally, so overriding that has little effect.
workmanw
force-pushed
the
setup-ember-dev-use-metal-hooks
branch
from
fd9dc9e to
2105fc3
Compare
|
Thanks @workmanw |
I've been helping to "addonify"® ember-data-model-fragments which also uses the
ember-devtest suite. I noticed thatexpectNoDeprecationswas no longer working as expected. After investigating I discovered that because Ember no longer usesEmber.deprecateinternally, overriding that has little effect. I checked to see how ember-data's test suite handled this and discovered you have the same problem. See: setup-ember-dev.js#L7-L13.This PR fixes that issue by using
ember-metal/debugproper hooks. This PR is meant to keep backwards compatibility and work with older versions of ember which did not offer these hooks. If the feeling is that ember and ember-data usage is truly lockstep, this PR could be simplified by removing thegetDebugFunctionandsetDebugFunctionall together. Example: ember-data-model-fragments/.../setup-ember-dev.js.Lastly, I ran the tests locally and there were quite a few failures due to deprecations spewing out. This PR was intended to start a discussion about that.Temporary insanity 😜 .