Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves the ember dep in the package-manager package.json into optionalDependencies #4243

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

CNDW
Copy link

@CNDW CNDW commented Mar 18, 2016

having ember in the dependencies forces a npm install of this repo to have a duplicate install of ember. If someone is installing ember/ember-data via the components shim library, their package.json will have to look something like this

    "components-ember": "https://github.com/components/ember/archive/2.4.2.tar.gz",
    "components-ember-data": "https://github.com/components/ember-data/archive/2.4.0.tar.gz",
    "ember": "https://github.com/emberjs/ember.js/archive/v2.4.2.tar.gz"

bmac added a commit that referenced this pull request Mar 18, 2016
moves the ember dep in the package-manager package.json into optionalDependencies
@bmac bmac merged commit e88dfed into emberjs:master Mar 18, 2016
@bmac
Copy link
Member

bmac commented Mar 18, 2016

Thanks @CNDW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants