Add blueprints from ember-cli-mocha #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 - This is the path that Ember will take also, once the blueprints land there (hint hint @Turbo87...). |
Turbo87
force-pushed
the
mocha-blueprints
branch
from
914dd6f to
286f32a
Compare
|
@Turbo87 would you mind squashing this pr into 1 commit and prefixing it with |
|
@bmac I'm not sure if that qualifies as a bugfix, but I can certainly do that. |
The filesPath() method will automatically figure out if "qunit" or "mocha" files should be used by looking at the project packages.
Turbo87
force-pushed
the
mocha-blueprints
branch
from
535592e to
7dc3218
Compare
|
done |
bmac
added a commit
that referenced
this pull request
Feb 17, 2016
Add blueprints from ember-cli-mocha
|
Thanks @Turbo87 |
This was referenced Feb 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the blueprints from
ember-cli-mochanext to the existingqunitblueprints. Duringember generatethe blueprints will automatically figure out what test framework to use based on the project dependencies. This approach was taken from adopted-ember-addons/ember-cp-validations#8.