Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for store#query() #4116

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Add assertions for store#query() #4116

merged 1 commit into from
Jan 27, 2016

Conversation

pangratz
Copy link
Member

Currently invoking store.query('person') will fail with an error
within RESTAdapter#sortQueryParams, which is not helpful.

This adds the following assertions to store#query():

  • a type is passed to the query method
  • a query hash is passed to the query method

Those two assertions are available on store#queryRecord so this PR aligns store#query so it has the same assertions.

@bmac
Copy link
Member

bmac commented Jan 27, 2016

Want to tag this [BUGFIX beta]?

Currently invoking `store.query('person')` will fail with an error
within `RESTAdapter#sortQueryParams`, which is not helpful.

This adds the following assertions to store#query():

- a type is passed to the query method
- a query hash is passed to the query method
bmac added a commit that referenced this pull request Jan 27, 2016
@bmac bmac merged commit eb83d5c into emberjs:master Jan 27, 2016
@pangratz pangratz deleted the add-assertions-for-query branch January 27, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants