Use Ember.merge instead of ember-data's shim
#4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shim was introduced to compatible with old Ember that couldn't merge object that has no `hasOwnProperty` method. emberjs#2506 However current Ember Data supports Ember >= 2 (it can merge objects safely since this change. 751f76dac ) emberjs/ember.js#5645 So now this shim is unnecessary.
|
LGTM 👍 |
|
LGTM |
bmac
added a commit
that referenced
this pull request
Jan 15, 2016
Use `Ember.merge` instead of ember-data's shim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shim was introduced to be compatible with old Ember
that couldn't merge object that has no
hasOwnPropertymethod.#2506
However current Ember Data supports Ember >= 2 (it can merge objects
safely since this change. emberjs/ember.js@751f76dac )
emberjs/ember.js#5645
So now this shim is unnecessary.