Improve InternalModel (2x - 3x faster) #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
changed the title
stefanpenner
force-pushed
the
internal-model
branch
from
0994346 to
17f58c7
Compare
stefanpenner
force-pushed
the
internal-model
branch
2 times, most recently
from
f8a0268 to
b6109d0
Compare
| var _extractPivotNameCache = Object.create(null); | ||
| var _splitOnDotCache = Object.create(null); | ||
| var _extractPivotNameCache = new EmberObject(); | ||
| var _splitOnDotCache = new EmberObject(); |
There was a problem hiding this comment.
Didn't you mean EmptyObject here too?
|
Lol late night patches. Will fix when I get to work |
|
How do we measure the speed? |
stefanpenner
force-pushed
the
internal-model
branch
from
b6109d0 to
ca9393f
Compare
how do you, or how did I? I just through together a quick one-off manual test. But the composed improvements are each well known to be very very worth while. |
|
i'll look at the tests shortly, i was an idiot and started moving other stuff around :P |
|
i think travis is in a bad state, the UI seems funky telling me this project isn't setup/configured. Tests appear green locally. |
|
@fivetanley @wecc @igorT any ideas whats up with travis and ED ?
cc @drogus |
|
looks like a test failure unrelated to this PR, it is present on master as is. Investigating |
…tly (I’m pretty sure i wrote the test in question…)
stefanpenner
added a commit
that referenced
this pull request
Aug 12, 2015
Improve InternalModel (2x - 3x faster)
jnfisher
added a commit
to jnfisher/data
that referenced
this pull request
Aug 22, 2015
emberjs#3641 Improve InternalModel (2x - 3x faster) emberjs#3649 Empty object
XrXr
pushed a commit
to XrXr/data
that referenced
this pull request
Sep 3, 2015
emberjs#3641 Improve InternalModel (2x - 3x faster) emberjs#3649 Empty object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.