[BUGFIX release] Update Ember.deprecate and Ember.warn calls to include required information
#3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
force-pushed
the
add-required-info-to-deprecations
branch
3 times, most recently
from
1f8c6e9
to
59f0aa9
Compare
HeroicEric
changed the title
Ember.deprecate and Ember.warn calls to include required informationEmber.deprecate and Ember.warn calls to include required information
|
@wecc this has all of the stuff from #3570 as well as anything additional that was left in the release branch. I assumed that everything that was still in the release branch but was no longer in master could be marked as |
| Ember.deprecate('DS.FixtureAdapter has been deprecated and moved into an unsupported addon: https://github.com/emberjs/ember-data-fixture-adapter/tree/master'); | ||
| Ember.deprecate('DS.FixtureAdapter has been deprecated and moved into an unsupported addon: https://github.com/emberjs/ember-data-fixture-adapter/tree/master', false, { | ||
| id: 'ds.adapter.fixture-adapter-deprecated', | ||
| until: '3.0.0' |
HeroicEric
force-pushed
the
add-required-info-to-deprecations
branch
from
59f0aa9
to
8cdd5c5
Compare
|
after talking to @bmac in slack, all deprecations/warnings are now marked as until 2.0.0 |
| Ember.warn(this.warnMessageNoModelForKey(prop, modelName), false); | ||
| Ember.warn(this.warnMessageNoModelForKey(prop, modelName), false, { | ||
| id: 'ds.serializer.model-for-key-missing', | ||
| until: '3.0.0' |
|
@wecc you're right "Warnings likewise will be required to pass a canonical id:" says nothing about requiring the until |
| Ember.warn('Ember Data expected to find records with the following ids in the adapter response but they were missing: ' + Ember.inspect(Ember.A(missingRecords).mapBy('id')), false); | ||
| Ember.warn('Ember Data expected to find records with the following ids in the adapter response but they were missing: ' + Ember.inspect(Ember.A(missingRecords).mapBy('id')), false, { | ||
| id: 'ds.store.missing-records-from-adapter', | ||
| until: '2.0.0' |
HeroicEric
force-pushed
the
add-required-info-to-deprecations
branch
from
8cdd5c5
to
f3ee1d1
Compare
|
All the |
|
@HeroicEric sweet! can you update the message (mentioned above) from |
|
And |
HeroicEric
force-pushed
the
add-required-info-to-deprecations
branch
from
f3ee1d1
to
d490ae2
Compare
|
@wecc done |
…lude required options
HeroicEric
force-pushed
the
add-required-info-to-deprecations
branch
from
d490ae2
to
7afbd99
Compare
wecc
added a commit
that referenced
this pull request
Jul 24, 2015
…tions [BUGFIX release] Update `Ember.deprecate` and `Ember.warn` calls to include required information
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3568 for release branch
Related: #3570