Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queryRecord method to the RESTAdapter #3554

Merged
merged 1 commit into from
Jul 22, 2015

Conversation

thaume
Copy link

@thaume thaume commented Jul 17, 2015

I just added the queryRecord to the RESTAdapter, it still needs more tests (coming soon)

@bmac
Copy link
Member

bmac commented Jul 17, 2015

Awesome. Thanks for getting to this @thaume

@wecc
Copy link
Contributor

wecc commented Jul 22, 2015

@thaume what's the status of this? anything I can do to help?

@thaume
Copy link
Author

thaume commented Jul 22, 2015

@wecc I just need to write a couple more tests, I'll try to do that today so that we can merge it before I leave for 2 weeks away from keyboard

@thaume
Copy link
Author

thaume commented Jul 22, 2015

@wecc @bmac I just added more tests, do you think we need more ? I feel like there are already many integration tests in the store/query-record-test file

@bmac
Copy link
Member

bmac commented Jul 22, 2015

@thaume What happens of posts in the response payload is an array instead of a single object?

@thaume
Copy link
Author

thaume commented Jul 22, 2015

@bmac It picks the record at index 0, but it still saves all the other records in the store. Do you think this is the intended result ? :)

@bmac
Copy link
Member

bmac commented Jul 22, 2015

I do. The tests look good. Can you squash these commits and prefix the commit with [BUGFIX release]?

@thaume thaume force-pushed the addQueryRecordRestAdapter branch from 6d6a955 to ce8b3ef Compare July 22, 2015 14:47
@thaume
Copy link
Author

thaume commented Jul 22, 2015

@bmac there you go

bmac added a commit that referenced this pull request Jul 22, 2015
Add queryRecord method to the RESTAdapter
@bmac bmac merged commit 3930e45 into emberjs:master Jul 22, 2015
@bmac
Copy link
Member

bmac commented Jul 22, 2015

Thanks

@wecc
Copy link
Contributor

wecc commented Jul 22, 2015

🎉

@thaume
Copy link
Author

thaume commented Jul 22, 2015

cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants