Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Model.rollback() to model.rollbackAttributes() #3305

Merged
merged 1 commit into from
Jun 12, 2015

Conversation

HeroicEric
Copy link
Member

Fixes #3273

  • renames Model.rollback() to Model.rollbackAttributes().
  • adds deprecation to Model.rollback()
  • renames InternalModel.rollback() to InternalModel.rollbackAttributes()

@igorT
Copy link
Member

igorT commented Jun 11, 2015

@HeroicEric Thanks! InternalModel sounds good as well if you want

@wecc
Copy link
Contributor

wecc commented Jun 12, 2015

LGTM

@bmac
Copy link
Member

bmac commented Jun 12, 2015

Looks good. @HeroicEric do you mind squashing these commits?

fivetanley added a commit that referenced this pull request Jun 12, 2015
Rename Model.rollback() to model.rollbackAttributes()
@fivetanley fivetanley merged commit 1dc03ca into emberjs:master Jun 12, 2015
@HeroicEric HeroicEric deleted the rename-rollback branch June 12, 2015 15:32
mikzar added a commit to mikzar/guides that referenced this pull request Sep 25, 2015
Ember Data renamed Model.rollback() to Model.rollbackAttributes().
(emberjs/data#3305)
locks pushed a commit to emberjs/guides that referenced this pull request Nov 3, 2015
Ember Data renamed Model.rollback() to Model.rollbackAttributes().
(emberjs/data#3305)
locks pushed a commit to emberjs/guides that referenced this pull request Nov 7, 2015
Ember Data renamed Model.rollback() to Model.rollbackAttributes().
(emberjs/data#3305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants