refactor store managed instances #3191

fivetanley · 2015-06-04T03:14:30Z

In this commit, we refactor store managed instance lookups to have its
own class that takes the store's container. This moves a large portion
of code out of the store and instead uses delegation.

There's also a performance benefit:

If you look up adapter:post and fallback to adapter:application,
this lookup is cached. So, if you look up adapter:post again, that
instance will actually be cached. Previously, we did the lookup for
adapter:post every time.

This also removes passing factories as the adapter property to
DS.Store.

closes #3050

bmac · 2015-06-04T08:25:46Z

packages/ember-data/lib/system/store.js

@@ -1958,30 +1943,28 @@ Store = Service.extend({
    @private
    @param {String} modelName the object modelName
    @param {String} name the object name
+    @param {Object} fallback the fallback object to return if the lookup for modelName or 'application' fails


{Array} fallbacks the list of the fallback objects...

In this commit, we refactor store managed instance lookups to have its own class that takes the store's container. This moves a large portion of code out of the store and instead uses delegation. There's also a performance benefit: If you look up `adapter:post` and fallback to `adapter:application`, this lookup is cached. So, if you look up `adapter:post` again, that instance will actually be cached. Previously, we did the lookup for `adapter:post` every time. This also removes passing factories as the `adapter` property to DS.Store. closes #3050

refactor store managed instances

igorT · 2015-06-04T14:56:20Z

👍

From emberjs#6166 This refactors some tests so that they don't rely on the `createStore` test helper. `createStore` was helpful in the past but is less so now that we have [nice APIs for dependency injection](https://guides.emberjs.com/release/applications/dependency-injection/). --- One test was removed from `unit/store/adapter-interop - Store working with a Adapter` because I don't think it was correct. Here was the test: https://github.com/emberjs/data/blob/39182f324d5777e4a75c4a582f0791631e37d8de/packages/-ember-data/tests/unit/store/adapter-interop-test.js#L28-L32 This test was, at one time, testing that it was possible to pass a factory as the `adapter` property to `Store`. This feature was removed in emberjs#3191 but the test continued passing because of the way the `createStore` works. https://github.com/emberjs/data/blob/39182f324d5777e4a75c4a582f0791631e37d8de/packages/-ember-data/tests/helpers/store.js#L57-L60

From #6166 This refactors some tests so that they don't rely on the `createStore` test helper. `createStore` was helpful in the past but is less so now that we have [nice APIs for dependency injection](https://guides.emberjs.com/release/applications/dependency-injection/). --- One test was removed from `unit/store/adapter-interop - Store working with a Adapter` because I don't think it was correct. Here was the test: https://github.com/emberjs/data/blob/39182f324d5777e4a75c4a582f0791631e37d8de/packages/-ember-data/tests/unit/store/adapter-interop-test.js#L28-L32 This test was, at one time, testing that it was possible to pass a factory as the `adapter` property to `Store`. This feature was removed in #3191 but the test continued passing because of the way the `createStore` works. https://github.com/emberjs/data/blob/39182f324d5777e4a75c4a582f0791631e37d8de/packages/-ember-data/tests/helpers/store.js#L57-L60

fivetanley force-pushed the refactor-serializer-adapter-lookup branch 3 times, most recently from f5c29e3 to 7251ef2 Compare June 4, 2015 03:52

bmac reviewed Jun 4, 2015
View reviewed changes

fivetanley force-pushed the refactor-serializer-adapter-lookup branch from 7251ef2 to b4d9033 Compare June 4, 2015 14:40

fivetanley force-pushed the refactor-serializer-adapter-lookup branch from b4d9033 to ee97760 Compare June 4, 2015 14:41

fivetanley added a commit that referenced this pull request Jun 4, 2015

Merge pull request #3191 from emberjs/refactor-serializer-adapter-lookup

f4eefab

refactor store managed instances

fivetanley merged commit f4eefab into master Jun 4, 2015

fivetanley deleted the refactor-serializer-adapter-lookup branch June 4, 2015 14:50

HeroicEric mentioned this pull request Aug 19, 2019

[CHORE] Refactor away from createStore test helper #6347

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor store managed instances #3191

refactor store managed instances #3191

fivetanley commented Jun 4, 2015

bmac Jun 4, 2015

igorT commented Jun 4, 2015

refactor store managed instances #3191

refactor store managed instances #3191

Conversation

fivetanley commented Jun 4, 2015

bmac Jun 4, 2015

Choose a reason for hiding this comment

igorT commented Jun 4, 2015