Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend adapter instead of reopening it #3139

Merged
merged 1 commit into from
Jun 1, 2015
Merged

Extend adapter instead of reopening it #3139

merged 1 commit into from
Jun 1, 2015

Conversation

ZenCocoon
Copy link
Contributor

Update documentation to recommend extended the adapter instead of reopening it.

wecc added a commit that referenced this pull request Jun 1, 2015
@wecc
Merge pull request #3139 from BookingSync/extend-adapter
0cf67bb 
Extend adapter instead of reopening it
@wecc wecc merged commit 0cf67bb into emberjs:master Jun 1, 2015
@ZenCocoon ZenCocoon deleted the extend-adapter branch June 1, 2015 22:33
@Turbo87
Copy link
Member

Turbo87 commented Jun 2, 2015

shouldn't we use export default DS.RESTAdapter.extend(...) instead, now that ember-cli is the recommended way of doing things?

@rwjblue
Copy link
Member

rwjblue commented Jun 2, 2015

Yes, that makes sense to me.

@igorT
Copy link
Member

igorT commented Jun 2, 2015

Yeah we need to go through all the docs and update

@Turbo87 Turbo87 mentioned this pull request Jun 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZenCocoon @Turbo87 @rwjblue @igorT @wecc