Merge attrs from superclasses into their subclasses.

[omghax]

This PR defines attrs as a mergedProperty, so it can be inherited from superclasses. This is useful if you have a polymorphic type and want to define a base serializer for common attributes.

[igorT]

Thanks

[pangratz]

Nice

[igorT]

Would be nice to point out somewhere in the docs

On Fri, May 8, 2015 at 11:13 PM, Clemens Müller [email protected]
wrote:

Nice

—
Reply to this email directly or view it on GitHub
#3055 (comment).

[pangratz]

What about merging hashes?

var BaseSerializer = DS.JSONSerializer.extend({
  attrs: {
    comments: {
      key: "le_comments"
    }
  }
});

var PostSerializer = BaseSerializer.extend({
  attrs: {
    comments: {
      anotherOptionForCustomSerializer: true
    }
  }
});

results currently in the following attrs hash:

{
  comments: {
    anotherOptionForCustomSerializer: true
  }
}

Do we want the result to be:

{
  comments: {
    key: "le_comments",
    anotherOptionForCustomSerializer: true
  }
}

??

[igorT]

I feel like having to look at multiple classes to be sure of what the hash
is pretty error prone. Not sure this is a really common use case and would
be confusing. Open to being persuaded otherwise

On Fri, May 8, 2015 at 11:22 PM, Clemens Müller [email protected]
wrote:

What about merging hashes?

var BaseSerializer = DS.JSONSerializer.extend({
attrs: {
comments: {
key: "le_comments"
}
}
});
var PostSerializer = BaseSerializer.extend({
attrs: {
comments: {
anotherOptionForCustomSerializer: true
}
}
});

results currently in the following attrs hash:

{
comments: {
anotherOptionForCustomSerializer: true
}
}

Do we want the result to be:

{
comments: {
key: "le_comments",
anotherOptionForCustomSerializer: true
}
}

??

—
Reply to this email directly or view it on GitHub
#3055 (comment).

[pangratz]

Yeah, you might be right that this is not a common use case ...

[omghax]

My mental model of attrs was that it behaved like actions in Ember, so I was a little surprised when that wasn't the case. Granted actions is flat, unlike attrs. I'm not in favor of recursively merging though, it seems like that would add more surprises.