Fix for deleting from ManyArray #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
fix-many-array-delete
branch
from
adaf7d0 to
1333191
Compare
| expect(4); | ||
|
|
||
| env.adapter.deleteRecord = function() { | ||
| return { id: 1 }; |
There was a problem hiding this comment.
you can just return RSVP.resolve() as deletion doesn't usually return data
wagenet
force-pushed
the
fix-many-array-delete
branch
from
1333191 to
4b6750f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if you delete the final object from a ManyArray elsewhere the following will happen:
objectAt(0)will still return a value.The issue appears to be that the
currentStateis correctly empty, but thecanonicalStatestill retains the deleted item. BecauseobjectAthas a fallback, we incorrectly use the value from thecanonicalState.