use typeKey and typeClass instead of using type inconsistently
#3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we exchanged type and typeKey intermittently. Sometimes it was one or the other. This changes most usages of `type` to either `typeKey` or `typeClass` for internal consistency. The API docs were also changed to reflect this. The Store API docs have been changed to suggest using a string for a future patchset where we don't take factories to the store finder methods.
fivetanley
added a commit
that referenced
this pull request
Apr 29, 2015
use typeKey and typeClass instead of using `type` inconsistently
|
❤️ ❤️ ❤️ I went through most of it, look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we exchanged type and typeKey intermittently. Sometimes it
was one or the other. This changes most usages of
typetoeither
typeKeyortypeClassfor internal consistency.The API docs were also changed to reflect this.
The Store API docs have been changed to suggest using a string
for a future patchset where we don't take factories to the store
finder methods.