ActiveModelAdapter camelizes keys for errors on 422 #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 27, 2015 14:13
Expects the error keys to be top-level:
For Ember Data to correctly map errors to their corresponding
properties on the model, Ember Data expects each error to be
namespaced under a key that matches the property name.
return Ember.RSVP.reject(new DS.InvalidError({
title: ['Must be unique'],
content: ['Must not be blank'],
}));
This was actually causing tests to pass that shouldn't have because of the
simple nature of `Ember.inspect`. E.g. comparing strings:
"Error: The backend rejected the commit because it was invalid: {errors: [object Object]}"
If a response is provided without an errors object then Ember Data will still work like it used to.
Error keys were arriving on models with underscores e.g.
human.errors.first_name
Addresses the test which was incorrectly passing
fivetanley
added a commit
that referenced
this pull request
Apr 29, 2015
ActiveModelAdapter camelizes keys for errors on 422
|
awesome, thanks! |
ghost
deleted the
|
@fivetanley @bdvholmes shouldn't camelCasing they keys be a concern of the serializer, and be done inside |
|
@pangratz is correct, this PR seems wrong |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields are not currently camelized in the model's errors object e.g.
should be
There is already test for this behavior but because of the way
InvalidErrorandEmber.inspectare implemented the test passes when it shouldn't do.ActiveModelAdapter now passes the errors hash directly to
InvalidErroras is expected according to the docs. This assumes that the 422 provides JSON of the formas is standard in active model. If
errorsis not present in the JSON response, active model adapter will continue to behave as it did before.