Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failing test for hasMany metadata scenario #2996

Closed
wants to merge 1 commit into from

Conversation

wecc
Copy link
Contributor

@wecc wecc commented Apr 13, 2015

Failing test for #2878 (comment)

@wecc wecc mentioned this pull request Apr 13, 2015
igorT added a commit that referenced this pull request Jun 6, 2015
Rebased #2878 and added a test from #2996
Added metadata support behind a feature flag, for hasMany relationships.
For now, until we refactor the internals, the store internally pushes hasMany
metadata around in the `meta` key next to `links` and `data`.
This might lead to overriding meta attribtues with meta relationships,
but will be solved by the upcoming change of the internals to JSONAPI format
@igorT igorT mentioned this pull request Jun 6, 2015
@igorT
Copy link
Member

igorT commented Jun 6, 2015

Superseded by #3221

@igorT igorT closed this Jun 6, 2015
igorT added a commit that referenced this pull request Jun 9, 2015
Rebased #2878 and added a test from #2996
Added metadata support behind a feature flag, for hasMany relationships.
For now, until we refactor the internals, the store internally pushes hasMany
metadata around in the `meta` key next to `links` and `data`.
This might lead to overriding meta attribtues with meta relationships,
but will be solved by the upcoming change of the internals to JSONAPI format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants