Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear meta data when unloading all records for a type. Fixes #2772 #2956

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Clear meta data when unloading all records for a type. Fixes #2772 #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ember-data/lib/system/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,7 @@ Store = Service.extend({
}

typeMap.findAllCache = null;
typeMap.metadata = Ember.create(null);
},

/**
Expand Down
18 changes: 18 additions & 0 deletions packages/ember-data/tests/integration/records/unload-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,24 @@ test("can unload all records for a given type", function () {
equal(env.store.all('person').get('length'), 0);
});

test("Unloading all records for a given type clears saved meta data.", function () {

function metadataKeys(type) {
return Ember.keys(env.store.metadataFor(type));
}

run(function() {
env.store.setMetadataFor('person', { count: 10 });
});

Ember.run(function() {
env.store.unloadAll('person');
});

deepEqual(metadataKeys('person'), [], 'Metadata for person is empty');

});

test("removes findAllCache after unloading all records", function () {
var adam, bob;
run(function() {
Expand Down