Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4600 introduced a spurious change event #4649

Closed
stefanpenner opened this issue Nov 11, 2016 · 1 comment
Closed

#4600 introduced a spurious change event #4649

stefanpenner opened this issue Nov 11, 2016 · 1 comment
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@stefanpenner
Copy link
Member

stefanpenner commented Nov 11, 2016 •
edited
Loading

Basically, now when accessing a relationship, it lazily builds itself (good) but while doing so it invalidates the property we just accessed (bad).

This is detected by glimmer, which nicely yells at you when you cause one (or more) of these extra churns.
stefanpenner added a commit that referenced this issue Nov 11, 2016
@stefanpenner
[BUGFIX #4649 #4648]
b3e1d67 
* no longer invalid relationships property when accessing it the first time #4649
* no longer duplicate  “notifyHasManyChange” when adding a record fixes #4648

No longer warn/error in glimmer 2 by accidentally causing duplicate work.
@stefanpenner stefanpenner mentioned this issue Nov 11, 2016
Merged
igorT added a commit that referenced this issue Nov 14, 2016
@igorT
Merge pull request #4643 from emberjs/fix-stuff
3093191 
[BUGFIX #4649 #4648]
@bmac
Copy link
Member

bmac commented Nov 16, 2016

@stefanpenner can this issue be closed now that #4643 is merged?

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @bmac @runspired