Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect test for unit/store/createRecord w/ camel-case string #3969

Closed
noazark opened this issue Dec 4, 2015 · 1 comment
Closed

Incorrect test for unit/store/createRecord w/ camel-case string #3969

noazark opened this issue Dec 4, 2015 · 1 comment

Comments

@noazark
Copy link

noazark commented Dec 4, 2015

I'll admit that I may be reading the intention of this test wrong, but it seems like there is a mismatch here:

https://github.com/emberjs/data/blob/master/tests/unit/store/create-record-test.js#L81

I believe this line should be:

record = store.createRecord('someThing', attributes);

Correct?

@pangratz
Copy link
Member

pangratz commented Dec 5, 2015

Good catch @noazark! But I think this test is obsolete in general since #3033. I think it would be save to remove it as a whole. Especially since test is a duplicate of the test below.

bmac added a commit to bmac/data that referenced this issue Dec 7, 2015
Closes emberjs#3969

This test has been obsolete since emberjs#3033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants