Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pushing real models in relationships into store.push #3271

Closed
igorT opened this issue Jun 9, 2015 · 5 comments
Closed

Deprecate pushing real models in relationships into store.push #3271

igorT opened this issue Jun 9, 2015 · 5 comments

Comments

@igorT
Copy link
Member

igorT commented Jun 9, 2015

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/store.js#L2059

this should deprecate

@fivetanley
Copy link
Member

This seems like a useful feature. What is the cost of supporting it?

@igorT
Copy link
Member Author

igorT commented Jun 9, 2015

Its not in json api
On Jun 9, 2015 5:37 AM, "Stanley Stuart" [email protected] wrote:

This seems like a useful feature. What is the cost of supporting it?


Reply to this email directly or view it on GitHub
#3271 (comment).

@igorT
Copy link
Member Author

igorT commented Jun 9, 2015

We could add a workaround if people really want it, but would want to wait
and see
On Jun 9, 2015 5:38 AM, "Igor Terzic" [email protected] wrote:

Its not in json api
On Jun 9, 2015 5:37 AM, "Stanley Stuart" [email protected] wrote:

This seems like a useful feature. What is the cost of supporting it?


Reply to this email directly or view it on GitHub
#3271 (comment).

@fivetanley
Copy link
Member

Oh wait, this is store.push. I agree. store.createRecord is the hook I use the most, if we support it there I'm happy. It's not a JSONApi hook per-se either.

@igorT
Copy link
Member Author

igorT commented Jun 9, 2015

Yes this is for push, not creating. This is much more useful when creating
On Jun 9, 2015 5:40 AM, "Stanley Stuart" [email protected] wrote:

Oh wait, this is store.push. I agree. store.createRecord is the hook I
use the most, if we support it there I'm happy. It's not a JSONApi hook
per-se either.


Reply to this email directly or view it on GitHub
#3271 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants