Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Data 1.0.0-beta.14.1/15 does not reload belongsTo relationship after reloading the record. #2795

Closed
stepanhav opened this issue Feb 16, 2015 · 5 comments
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@stepanhav
Copy link

After upgrading to version 1.0.0-beta.14.1 I noticed that after the record is reloaded, the belongsTo relationships that was changed are not restored to original value.

Here is the jsbin that demonstrate that http://jsbin.com/cuxozoneji/1/edit?html,js,output

In previous version 1.0.0-beta.12 this worked as I would expected. 1.0.0-beta.15 works the same as 1.0.0-beta.14.1.

@bmac bmac added the Bug label Feb 16, 2015
@bmac
Copy link
Member

bmac commented Feb 16, 2015

Thanks for opening this @stepanhav. Its defiantly a bug. I suspect this is related to some of the relationship refactoring that went into 1.0.0-beta.14.1. I'll dig into this some more to try and identify where the relationship should be reset.

edzen pushed a commit to OLDZenefits/emberjs-data that referenced this issue Mar 20, 2015
@jcollins1991-zenefits
Copy link

@igorT ping? running into this ;(

@nfc036
Copy link

nfc036 commented Apr 28, 2015

+1. Bug still exists in ember-data#1.0.0-beta.16.1 !?

@wecc
Copy link
Contributor

wecc commented Sep 16, 2015

This seem to still be an issue in ED 1.13 / 2.0

@wecc
Copy link
Contributor

wecc commented Oct 22, 2016

I'm going to close this since I'm unable to reproduce this issue using Ember release and Ember Data canary, see https://ember-twiddle.com/0fc88a0a411c2aae0f712fcbc26babd8

As you can see model.rollbackAttributes() is needed to rollback the actual attributes, but the relationship is always updated. This will improve with emberjs/rfcs#21

@wecc wecc closed this as completed Oct 22, 2016
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

No branches or pull requests

6 participants