Add eslint-plugin-n to eslint config for node files

emberjs · Oct 25, 2023 · 6c85b6b · 6c85b6b
1 parent fb5b968
commit 6c85b6b
Show file tree

Hide file tree

Showing 32 changed files with 80 additions and 33 deletions.
diff --git a/config/eslint/node.cjs b/config/eslint/node.cjs
@@ -1,6 +1,8 @@
 function defaults(config) {
   const result = {
-    files: !config?.useModules ? ['./babel.config.js', './.eslintrc.cjs', './index.js', './addon-main.cjs', './addon-main.js'] : [],
+    files: !config?.useModules
+      ? ['./babel.config.js', './.eslintrc.cjs', './index.js', './addon-main.cjs', './addon-main.js']
+      : [],
     parserOptions: {
       sourceType: config?.useModules ? 'module' : 'script',
       ecmaVersion: 2022,
@@ -11,6 +13,8 @@ function defaults(config) {
       es6: true,
     },
     globals: config?.globals || {},
+    plugins: ['n'],
+    extends: 'plugin:n/recommended',
   };
 
   if (config?.files) {
@@ -21,5 +25,5 @@ function defaults(config) {
 }
 
 module.exports = {
-  defaults
+  defaults,
 };
diff --git a/config/eslint/parser.cjs b/config/eslint/parser.cjs
@@ -6,7 +6,7 @@ function defaults() {
       ecmaVersion: 2022,
       sourceType: 'module',
       babelOptions: {
-        // eslint-disable-next-line node/no-unpublished-require
+        // eslint-disable-next-line n/no-unpublished-require
         plugins: [[require.resolve('@babel/plugin-proposal-decorators'), { legacy: true }]],
       },
       requireConfigFile: false,
@@ -15,5 +15,5 @@ function defaults() {
 }
 
 module.exports = {
-  defaults
+  defaults,
 };
diff --git a/config/package.json b/config/package.json
@@ -11,6 +11,7 @@
     "eslint": "^8.52.0",
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-n": "^16.2.0",
     "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-simple-import-sort": "^10.0.0",
     "prettier": "^3.0.3",
@@ -23,4 +24,4 @@
     "extends": "../../package.json"
   },
   "packageManager": "[email protected]"
-}
+}
diff --git a/packages/private-build-infra/src/utilities/detect-module.js b/packages/private-build-infra/src/utilities/detect-module.js
@@ -75,7 +75,7 @@ module.exports = function detectModule(require, moduleName, baseDir, pkg) {
         bustCache(require);
         // ember-data brings all packages so if present we are present
         //
-        // eslint-disable-next-line node/no-missing-require
+        // eslint-disable-next-line n/no-missing-require
         require.resolve('ember-data', { paths: [baseDir, path.join(baseDir, '../'), process.cwd()] });
         log('\t✅ FOUND ember-data');
         return true;

diff --git a/packages/unpublished-test-infra/ember-cli-build.js b/packages/unpublished-test-infra/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/packages/unpublished-test-infra/index.js b/packages/unpublished-test-infra/index.js
@@ -1,5 +1,5 @@
 'use strict';
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const merge = require('broccoli-merge-trees');
 const version = require('@ember-data/private-build-infra/src/create-version-module');
 const addonBuildConfigForDataPackage = require('@ember-data/private-build-infra/src/addon-build-config-for-data-package');

diff --git a/packages/unpublished-test-infra/src/testem/testem.js b/packages/unpublished-test-infra/src/testem/testem.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 /* eslint-disable no-console */
 const fs = require('node:fs');
 const path = require('node:path');

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/builders/ember-cli-build.js b/tests/builders/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/docs/index.js b/tests/docs/index.js
@@ -25,7 +25,7 @@ function linkItem(item) {
 
 QUnit.module('Docs coverage', function (hooks) {
   // data.json is generated and not always present. So this disable needs to be preserved.
-  const docs = require('../../packages/-ember-data/dist/docs/data.json'); // eslint-disable-line node/no-missing-require
+  const docs = require('../../packages/-ember-data/dist/docs/data.json'); // eslint-disable-line n/no-missing-require
   const expected = require('./fixtures/expected');
 
   function classIsPublic(className) {

diff --git a/tests/ember-data__adapter/ember-cli-build.js b/tests/ember-data__adapter/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/tests/ember-data__graph/ember-cli-build.js b/tests/ember-data__graph/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/ember-data__json-api/ember-cli-build.js b/tests/ember-data__json-api/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/ember-data__model/ember-cli-build.js b/tests/ember-data__model/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/tests/ember-data__request/ember-cli-build.js b/tests/ember-data__request/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/ember-data__serializer/ember-cli-build.js b/tests/ember-data__serializer/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/tests/ember-data__serializer/testem.js b/tests/ember-data__serializer/testem.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

diff --git a/tests/embroider-basic-compat/ember-cli-build.js b/tests/embroider-basic-compat/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/tests/embroider-basic-compat/testem.js b/tests/embroider-basic-compat/testem.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

diff --git a/tests/fastboot/ember-cli-build.js b/tests/fastboot/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/tests/fastboot/testem.js b/tests/fastboot/testem.js
@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

diff --git a/tests/full-data-asset-size-app/ember-cli-build.js b/tests/full-data-asset-size-app/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/main/config/ember-try.js b/tests/main/config/ember-try.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');

diff --git a/tests/main/ember-cli-build.js b/tests/main/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/main/testem.js b/tests/main/testem.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 const TestemConfig = require('@ember-data/unpublished-test-infra/src/testem/testem');
 
 module.exports = TestemConfig;
diff --git a/tests/performance/ember-cli-build.js b/tests/performance/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

diff --git a/tests/recommended-json-api/ember-cli-build.js b/tests/recommended-json-api/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/recommended-json-api/server/index.js b/tests/recommended-json-api/server/index.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 // To use it create some files under `mocks/`

diff --git a/tests/recommended-json-api/server/mocks/book.js b/tests/recommended-json-api/server/mocks/book.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 const RAW_BOOKS = require('./MOCK_DATA.json');
 

diff --git a/tests/recommended-json-api/testem.js b/tests/recommended-json-api/testem.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

diff --git a/tests/warp-drive__schema-record/ember-cli-build.js b/tests/warp-drive__schema-record/ember-cli-build.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

diff --git a/tests/warp-drive__schema-record/testem.js b/tests/warp-drive__schema-record/testem.js
@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console