Skip to content

Commit

Permalink
make extra sure we aren't trolling ourselves
Browse files Browse the repository at this point in the history
  • Loading branch information
runspired committed Nov 26, 2019
1 parent bea016c commit 67dc107
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions bin/test-external-partner-project.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,16 @@ try {
try {
debug('Preparing Package To Run Tests Against Commit');
insertTarballsToPackageJson(packageJsonLocation);
// lock files may bring in other versions of EmberData that otherwise
// would have resolved to our desired version
execExternal(`rm -rf node_modules package-lock.json yarn.lock`);

// clear node_modules installed for the smoke-test
execExternal(`rm -rf node_modules`);
// we are forced to use yarn so that our resolutions will be respected
// in addition to the version file link we insert otherwise nested deps
// may bring their own ember-data
execExternal(`yarn install`);
//
// For this reason we don't trust the lock file
// we also can't trust the cache
execExternal(`yarn install --no-lockfile --cache-folder=tmp/yarn-cache`);
} catch (e) {
console.log(`Unable to npm install tarballs for ember-data\` for ${externalProjectName}. Original error below:`);

Expand Down

0 comments on commit 67dc107

Please sign in to comment.