Initial lint config for tests/blueprints

config/eslint/node.cjs

@@ -1,16 +1,25 @@
-function defaults(config) {
+function defaults(config = {}) {
   const result = {
-    files: !config?.useModules ? ['./babel.config.js', './.eslintrc.cjs', './index.js', './addon-main.cjs', './addon-main.js'] : [],
+    files: !config.useModules
+      ? ['./babel.config.js', './.eslintrc.cjs', './index.js', './addon-main.cjs', './addon-main.js']
+      : [],
     parserOptions: {
-      sourceType: config?.useModules ? 'module' : 'script',
+      sourceType: config.useModules ? 'module' : 'script',
       ecmaVersion: 2022,
     },
     env: {
       browser: false,
       node: true,
       es6: true,
+      ...config.env,
+    },
+    globals: config.globals || {},
+    plugins: ['n', 'import'],
+    extends: 'plugin:n/recommended',
+    rules: {
+      'import/order': ['error', { 'newlines-between': 'always' }],
+      ...config.rules,
     },
-    globals: config?.globals || {},
   };
 
   if (config?.files) {
@@ -21,5 +30,5 @@ function defaults(config) {
 }
 
 module.exports = {
-  defaults
+  defaults,
 };

config/eslint/parser.cjs

@@ -6,7 +6,7 @@ function defaults() {
       ecmaVersion: 2022,
       sourceType: 'module',
       babelOptions: {
-        // eslint-disable-next-line node/no-unpublished-require
+        // eslint-disable-next-line n/no-unpublished-require
         plugins: [[require.resolve('@babel/plugin-proposal-decorators'), { legacy: true }]],
       },
       requireConfigFile: false,
@@ -15,5 +15,5 @@ function defaults() {
 }
 
 module.exports = {
-  defaults
+  defaults,
 };

config/package.json

@@ -11,6 +11,7 @@
     "eslint": "^8.52.0",
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-n": "^16.2.0",
     "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-simple-import-sort": "^10.0.0",
     "pnpm-sync-dependencies-meta-injected": "0.0.10",
@@ -24,4 +25,4 @@
     "extends": "../../package.json"
   },
   "packageManager": "[email protected]"
-}
+}

packages/private-build-infra/src/utilities/detect-module.js

@@ -75,7 +75,7 @@ module.exports = function detectModule(require, moduleName, baseDir, pkg) {
         bustCache(require);
         // ember-data brings all packages so if present we are present
         //
-        // eslint-disable-next-line node/no-missing-require
+        // eslint-disable-next-line n/no-missing-require
         require.resolve('ember-data', { paths: [baseDir, path.join(baseDir, '../'), process.cwd()] });
         log('\t✅ FOUND ember-data');
         return true;

packages/unpublished-test-infra/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

packages/unpublished-test-infra/index.js

@@ -1,5 +1,5 @@
 'use strict';
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const merge = require('broccoli-merge-trees');
 const version = require('@ember-data/private-build-infra/src/create-version-module');
 const addonBuildConfigForDataPackage = require('@ember-data/private-build-infra/src/addon-build-config-for-data-package');

packages/unpublished-test-infra/src/testem/testem.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 /* eslint-disable no-console */
 const fs = require('node:fs');
 const path = require('node:path');

tests/blueprints/.eslintrc.cjs

@@ -0,0 +1,43 @@
+const imports = require('@warp-drive/internal-config/eslint/imports.cjs');
+const parser = require('@warp-drive/internal-config/eslint/parser.cjs');
+const isolation = require('@warp-drive/internal-config/eslint/isolation.cjs');
+const ignore = require('@warp-drive/internal-config/eslint/ignore.cjs');
+const node = require('@warp-drive/internal-config/eslint/node.cjs');
+const base = require('@warp-drive/internal-config/eslint/base.cjs');
+
+module.exports = {
+  ...parser.defaults(),
+
+  plugins: [...base.plugins(), ...imports.plugins()],
+  extends: [...base.extend()],
+  rules: Object.assign(
+    base.rules(),
+    imports.rules(),
+    // { allowedImports: ['@ember/debug', 'ember-inflector', '@ember/string'] }
+    isolation.rules(),
+    {}
+  ),
+
+  ignorePatterns: ignore.ignoreRules(),
+
+  overrides: [
+    node.defaults({
+      useModules: true,
+      files: ['tests/**/*.{js,ts}'],
+      env: {
+        mocha: true,
+      },
+      rules: {
+        'n/no-unpublished-require': 'off',
+      },
+    }),
+    node.defaults({
+      useModules: true,
+      files: ['fixtures/**/*.{js,ts}'],
+      rules: {
+        'import/order': 'off',
+        'simple-import-sort/imports': 'off',
+      },
+    }),
+  ],
+};

tests/blueprints/package.json

@@ -11,6 +11,7 @@
   "license": "MIT",
   "author": "",
   "scripts": {
+    "lint": "eslint . --quiet --cache --cache-strategy=content --ext .js,.ts,.mjs,.cjs",
     "test:blueprints": "mocha tests",
     "_syncPnpm": "bun run sync-dependencies-meta-injected"
   },
@@ -89,6 +90,7 @@
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",
     "@warp-drive/core-types": "workspace:5.5.0-alpha.11",
+    "@warp-drive/internal-config": "workspace:5.5.0-alpha.11",
     "ember-cli": "~5.3.0",
     "ember-cli-blueprint-test-helpers": "^0.19.2",
     "ember-inflector": "^4.0.2",

tests/builders/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/docs/index.js

@@ -25,7 +25,7 @@ function linkItem(item) {
 
 QUnit.module('Docs coverage', function (hooks) {
   // data.json is generated and not always present. So this disable needs to be preserved.
-  const docs = require('../../packages/-ember-data/dist/docs/data.json'); // eslint-disable-line node/no-missing-require
+  const docs = require('../../packages/-ember-data/dist/docs/data.json'); // eslint-disable-line n/no-missing-require
   const expected = require('./fixtures/expected');
 
   function classIsPublic(className) {

tests/ember-data__adapter/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

tests/ember-data__graph/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/ember-data__json-api/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/ember-data__model/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

tests/ember-data__request/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/ember-data__serializer/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

tests/ember-data__serializer/testem.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

tests/embroider-basic-compat/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

tests/embroider-basic-compat/testem.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

tests/fastboot/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

tests/fastboot/testem.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-unpublished-require
+// eslint-disable-next-line n/no-unpublished-require
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

tests/full-data-asset-size-app/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/main/config/ember-try.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const getChannelURL = require('ember-source-channel-url');

tests/main/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/main/testem.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 const TestemConfig = require('@ember-data/unpublished-test-infra/src/testem/testem');
 
 module.exports = TestemConfig;

tests/performance/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint node/no-unpublished-require: 'off' */
+/* eslint n/no-unpublished-require: 'off' */
 
 'use strict';
 

tests/recommended-json-api/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/recommended-json-api/server/index.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 // To use it create some files under `mocks/`

tests/recommended-json-api/server/mocks/book.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 const RAW_BOOKS = require('./MOCK_DATA.json');
 

tests/recommended-json-api/testem.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console

tests/warp-drive__schema-record/ember-cli-build.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 'use strict';
 
 const EmberApp = require('ember-cli/lib/broccoli/ember-app');

tests/warp-drive__schema-record/testem.js

@@ -1,4 +1,4 @@
-/* eslint-disable node/no-unpublished-require */
+/* eslint-disable n/no-unpublished-require */
 const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
 
 // eslint-disable-next-line no-console