clear initialState after construction (#7110)

emberjs · Apr 24, 2020 · 605b3ba · 605b3ba
1 parent 5feedc8
commit 605b3ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/-ember-data/tests/integration/relationships/has-many-test.js b/packages/-ember-data/tests/integration/relationships/has-many-test.js
@@ -179,7 +179,7 @@ module('integration/relationships/has_many - Has-Many Relationships', function(h
   });
 
   test('hasMany + canonical vs currentState + destroyRecord  ', function(assert) {
-    assert.expect(6);
+    assert.expect(7);
 
     let store = this.owner.lookup('service:store');
 
@@ -266,6 +266,8 @@ module('integration/relationships/has_many - Has-Many Relationships', function(h
     );
     assert.equal(contacts, user.get('contacts'));
 
+    assert.ok(!user.contacts.initialState || !user.contacts.initialState.find(model => model.id === '2'));
+
     run(() => {
       contacts.addObject(store.createRecord('user', { id: 8 }));
     });

diff --git a/packages/model/addon/-private/system/many-array.js b/packages/model/addon/-private/system/many-array.js
@@ -136,6 +136,8 @@ export default EmberObject.extend(MutableArray, DeprecatedEvented, {
     */
     this.currentState = [];
     this.flushCanonical(this.initialState, false);
+    // we don't need this anymore, it just prevents garbage collection the records in the initialState
+    this.initialState = undefined;
   },
 
   // TODO: if(DEBUG)