-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Await potentially async operations (#6441)
Some operations in Ember Data flush using `run.join`. This will flush _synchronously_ if no runloop or autorun currently exists, but will join the existing runloop otherwise, making the scheduled task effectively asynchronous. With the tracked properties feature flag enabled, the way we've scheduled autoruns has changed. A few Data tests were failing because they were expecting an operation to flush synchronously, but it flushed asynchronously due to an existing autorun. This PR adds appropriate `await settled();` statements in these cases.
- Loading branch information
Showing
2 changed files
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters