-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX beta] rollbackAttributes() works after multiple failed saves
A rollback of dirty attributes didn't work correctly when a model is saved more than 1 time and the save fails. The issue is that the `exit` handler on the invalid state - which is called when the model is saved again and it is transitioned into the inFlight state - clears the `_inFlightAttributes` which unfortunately wipes all the data needed to rollback attributes. The exit handler has been implemented in the course of #1755, but the reported issue in that PR seems to be fixed ever since elsewhere in the code base, since the added test back test still is green. (cherry picked from commit 6f9560e) Conflicts: packages/ember-data/lib/system/model/states.js
- Loading branch information
Showing
2 changed files
with
43 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters