GJS: Add tests to ensure flat-configs work with the parser #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NullVoxPopuli
force-pushed
the
flat-config
branch
from
9bf9fbd to
06b5799
Compare
patricklx
reviewed
Jan 30, 2024
| }, | ||
| { | ||
| files: ['**/*.gjs'], | ||
| languageOptions: { |
There was a problem hiding this comment.
Gjs needs the same parser config like *.js
There was a problem hiding this comment.
It's normally not a problem since a config file is used
There was a problem hiding this comment.
O guess we should document it. That internally babel parser is used. Or should we just add some default plugins?
There was a problem hiding this comment.
I think we should document it, and then let eslint-plugin-ember decide if some utilities or defaults would be helpful to configure
|
Thanks for fixing wy pr! I'm going to setup a gts version, too |
NullVoxPopuli
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some debugging / exploration of flat configs to try to debug: ember-cli/eslint-plugin-ember#2061