Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-invalid-link-text and no-invalid-meta to octane configuration. #996

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

MelSumner
Copy link
Contributor

adds in two rules we just merged

adds in two rules we just merged
@MelSumner MelSumner requested a review from rwjblue December 12, 2019 20:54
@rwjblue rwjblue changed the title Update octane.js Add no-invalid-link-text and no-invalid-meta to octane configuration. Dec 12, 2019
@rwjblue rwjblue merged commit 2d35c7e into master Dec 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/add-new-a11y-rules branch December 12, 2019 21:03
@Turbo87
Copy link
Member

Turbo87 commented Dec 12, 2019

same question as on the other PR, isn't this a breaking change? 🤔

Copy link
Member

rwjblue commented Dec 13, 2019

No, the octane preset is in preview state (the same as the rest of octane stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants