Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid suggesting unless with helpers in condition in no-negated-condition rule #613

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Avoid suggesting unless with helpers in condition in no-negated-condition rule #613

merged 1 commit into from
Jan 17, 2019

Conversation

bmish
Copy link
Member

@bmish bmish commented Jan 17, 2019

We don't want to suggest turning this:

<img class={{if (not (or c1 c2)) "some-class"}}>

into this:

<img class={{unless (or c1 c2) "some-class"}}>

as the simple-unless rule does not permit helpers to be used with unless.

@rwjblue rwjblue added the bug label Jan 17, 2019
@rwjblue rwjblue merged commit 7ea4dcc into ember-template-lint:master Jan 17, 2019
@rwjblue rwjblue changed the title fix: avoid suggesting 'unless' with helpers in condition in 'no-negated-condition' rule. Avoid suggesting unless with helpers in condition in no-negated-condition rule Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmish @rwjblue